🚇🩹 Use pinned versions of dependencies to run integration CI tests #892
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the integration tests CI installs the latest versions available and allowed by 'pyglotaran's 'setup.cfg'. I case of a breaking update in a dependency this breaks all CI workflows, thus it is better to use the pinned versions from 'requirements_dev.txt' so only breaking changes break the CI.
|
|
s-weigand
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #892 +/- ##
=====================================
Coverage 84.7% 84.7%
=====================================
Files 81 81
Lines 4596 4596
Branches 849 849
=====================================
Hits 3897 3897
Misses 558 558
Partials 141 141 Continue to review full report at Codecov.
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the integration tests CI installs the latest versions available and allowed by
pyglotaranssetup.cfg. I case of a breaking update in a dependency this breaks all CI workflows, thus it is better to use the pinned versions from 'requirements_dev.txt' so only breaking changes break the CI.An example can be seen in PR #890 and this CI run, where the CI breaks because of a new version of
xarraywhich is unrelated to the PR itself.Change summary
Checklist